Daimona added a comment.
In T300306#7778299 <https://phabricator.wikimedia.org/T300306#7778299>, @Jdlrobson wrote: > @Daimona message boxes were designed intentionally to not have attributes. If an element is using custom attributes then there are 3 options: > > - Make the message box a child of an element which has those attributes > - Make the child have these attributes > - Replace the attributes with a class if possible Makes sense to me. > Is there an example of code which wouldn't work with any of those options? No idea, I guess we could try and apply these options to the remaining uses in core. I still think it may be a good idea to have the get...Classes() methods for code that is not easy to migrate. The documentation of those methods could state that usage is discouraged and that they will be removed in the future. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Krinkle, Edtadros, Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Fernandobacasegua34, Astuthiodit_1, 786, fenpedia, Suran38, Biggs657, karapayneWMDE, toberto, bwang, Invadibot, Feldpauschhaylee2017, LaMagiaaa, Lalamarie69, Zabe, Asartea, Florian_COLLIN, R4356th, Bebiezaza, maantietaja, Wilmanbeno, Juan90264, Alter-paule, Beast1978, CBogen, GeneralNotability, Un1tY, FelixE2019, Akuckartz, Dzaky17, Hook696, CptViraj, darthmon_wmde, ST47, WDoranWMF, Majavah, Kent7301, Chambersjay, RhinosF1, EvanProdromou, joker88john, SD0001, 94rain, DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, Tks4Fish, Tumzaaaa24, Gaboe420, Jony, CycloneIsaac, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Minilexikon, Bsandipan, Gboyers, GoranSMilovanovic, ihojose, Mahir256, QZanden, LawExplorer, Litanwei, spatton, Samuele2002, Lewizho99, JJMC89, Maathavan, SundanceRaphael, _jensen, Jseddon, rosalieper, Agabi10, AGK, XanonymusX, Neuronton, RuyP, JEumerus, gabriel-wmde, Scott_WUaS, mb, Cirdan, Pchelolo, DStrine, XenoRyet, Wong128hk, Luke081515, Nirmos, Bsadowski1, mys_721tx, I_JethroBT, Unapersona, Zache, alex-mashin, Niharika, Wikidata-bugs, Snowolf, Base, aude, AndyRussG, Ebe123, Nullzero, Pcoombe, Huji, Dinoguy1000, jeblad, jayvdb, MrStradivarius, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, KartikMistry, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Glaisher, Krenair, jeremyb, Legoktm
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
