tstarling added a comment.
In T308443#7931024 <https://phabricator.wikimedia.org/T308443#7931024>, @Lucas_Werkmeister_WMDE wrote: > The patch includes a “ResourceLoaderContext72Hack” hack class, which is apparently supposed to work around T166010#5962098 <https://phabricator.wikimedia.org/T166010#5962098>. Perhaps that hack, whatever it is, doesn’t work in Phan? No, that issue is not relevant for Phan. I'm currently trying to figure out how to run Phan against this extension locally. For some reason it doesn't pick up Wikibase/vendor and then throws errors about all the classes from there being missing e.g. WikibaseLexeme.datatypes.client.php:8 PhanUndeclaredTypeParameter Parameter $options has undeclared type \ValueFormatters\FormatterOptions But the CI console does not show this package being installed so I'm not sure how it avoids the error. This is with MW_INSTALL_PATH set, without that variable phan just passes. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: tstarling Cc: Reedy, ItamarWMDE, Michael, RhinosF1, Krinkle, tstarling, kostajh, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, Akuckartz, DannyS712, Nandana, Lahi, Gq86, Daimona, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
