tstarling added a comment.
Basically it looks like at least a day of my time wasted debugging issues specific to the dinosaur version of PHP we are running in production. Potential fixes: - Patch all affected extensions to use the new class name. The core patch would be reapplied and the extension patches would be immediately merged. Would break anything using phan without release branches. - Add @phan-suppress to all affected methods in extensions. - Patch phan. Wastes upstream's time with ancient PHP version issues, and probably incurs a rebase cost when reapplying the core patch, due to phan deployment delay. - Temporarily have the core class use the old name in its signatures, and suppress the phan issues which will occur due to core having enable_class_alias_support=false - Forget it for now. Rebasing in future will be complex, so this option probably adds half a day to the project. - Upgrade to PHP 7.4 in production. Could be done in a few days and we need to do it anyway. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: tstarling Cc: Reedy, ItamarWMDE, Michael, RhinosF1, Krinkle, tstarling, kostajh, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, Akuckartz, DannyS712, Nandana, Lahi, Gq86, Daimona, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
