bmartinezcalvo added a comment.
In T306932#8299386 <https://phabricator.wikimedia.org/T306932#8299386>, @EUdoh-WMF wrote: > @Catrope @SaraiSan > > 1.Chrome v106: At 175% zoom, there is a faint blue border at the top of the first menu item. > F35552654: image.png <https://phabricator.wikimedia.org/F35552654> @EUdoh-WMF that blue border also appears to me just when the menu is scrollable. | F35619237: Captura de Pantalla 2022-10-24 a las 9.55.34.png <https://phabricator.wikimedia.org/F35619237> | F35619244: Captura de Pantalla 2022-10-24 a las 9.56.45.png <https://phabricator.wikimedia.org/F35619244> | | scrollable menu (with blue border) | not scrollable menu (without blue border) | | Although this blue border appears when the screen is 175% zoom, it doesn't appear when the screen is 100% zoom or other zoom than 175%. So I don't see this blue border as a blocker since it only affects the 175% zoom which I don't think is very common while users browse. --- > 2. Chrome v106: At 125% zoom and with a number of visible items as 1, there appears to be a bottom border with some markings or text reflections. This shows up as an white space on Firefox v105 > > | F35552673: image.png <https://phabricator.wikimedia.org/F35552673> | F35552677: image.png <https://phabricator.wikimedia.org/F35552677> | > | I agree, when the number of visible items is 1 there is 1px with no white background and the text "Number of visible items in Menu" below the menu component is visible between that 1px transparent. F35619300: GrabacioĢn de pantalla 2022-10-21 a las 11.22.54.mov <https://phabricator.wikimedia.org/F35619300> --- > 3. All browsers: when the text input has focus, its blue border outline should be of equal thickness all over the component, as designed. In the demo page, the bottom border outline is thinner. > > | F35552660: image.png <https://phabricator.wikimedia.org/F35552660> | F35552663: image.png <https://phabricator.wikimedia.org/F35552663> | > | @EUdoh-WMF I agree, as specified in the Figma spec <https://www.figma.com/file/o9a6npqkhuEiZ3PsURXIyF/Menu%3A-Configurable-scroll---T306933?node-id=1%3A3210> the focus should border should be 2px if possible on all sides. F35619288: Captura de Pantalla 2022-10-24 a las 10.05.00.png <https://phabricator.wikimedia.org/F35619288> TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EUdoh-WMF, bmartinezcalvo Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
