Sarai-WMDE added a comment.
Hey all. Regarding the removal of that //-1px// border-top. The change (which I still support) was suggested a while back (see original task, T307767 <https://phabricator.wikimedia.org/T307767>): me and Alex <https://phabricator.wikimedia.org/T303558#8012171> noticed that cdx-TypeaheadSearch was misaligned with the original TahS – and other components – in production. After consulting the Product design team (via Slack), some members also expressed their preference for this new visual approach. I decided to capture this desired new direction in the designs (also, at the time, Figma didn't allow negative autolayout!). This was brought for discussion with the DST, and the task was put on hold due to issues mentioned by @Volker_E in this comment: https://phabricator.wikimedia.org/T307767#8026555";. (I believe he meant to write "Issues with adjacent (Option B)", btw). So, this is blocked by an internal disagreement that we should try to resolve. > The reason for the -1px negative margin in past design decision in OOUI was to make sure the menu is overlaying the calling element, to also support the elevated layering with this visual detail It's very common for menus to not touch (or even have a 1px margin separation with) their inputs, and rely on box-shadow to convey elevation. I don't think that the border overlap is essential to reinforce that, and that on the contrary, the result of having active inputs that present even borders is very desirable. Again, I'd support moving ahead in this direction. Nevertheless, I understand the logic behind your concern. A way to reduce that "Escher effect" potentially caused by adjacent menus could be to apply a 2px to all menu's border-radius. We can discuss this in a follow-up design round. I think that this approach would 1. allow us to convey elevation, while 2. keeping the menu from overlapping with the input, and 3. removing the need to flip border radius for upward-opening menus. I know it's quite a different direction, but had to share as it seems to be convenient. F35649749: Screenshot 2022-10-28 at 15.56.15.png <https://phabricator.wikimedia.org/F35649749> TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EUdoh-WMF, Sarai-WMDE Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
