Addshore added a comment. Restricted Application added a project: User-ItamarWMDE.
In T326082#8512537 <https://phabricator.wikimedia.org/T326082#8512537>, @ItamarWMDE wrote: > **Task Breakdown Notes**: > > - Calrification: This involves the following steps: > 1. Creating an item in a wikibase instance > 2. Linking that item into a client wiki > 3. Linking the item into another client wiki > 4. Deleting the wikidata item does not result in the removal of sitelinks between the two wiki pages, no removal of the sitelink appears in recent changes either Correct. No notification is given to the client at all that the entity was deleted. This included the removal of interwiki links if an item is linked to multiple pages, and those pages thus have interwiki links But this also includes for example the "data item" link the side bar, or displaying infomation about the linked item on the page info page (such as the ID). Thus in a minimal reproduction you only need 1 repo and 1 client and to follow these steps 1. Creating an item in a wikibase instance 2. Linking that item into a client wiki 3. Delete that item 4. Deleting the item does notify the client the item was deleted, and thus does not result in removal of interwiki links on the client page, or removal of the data item link from the side page, or item infomation from page info. > - This is going to be difficult to reproduce locally > - We believe the regression was introduced when we rewrote the change dispatching system into a MediaWiki job > - Might be able to test this in one wiki alone, since change propagation seems to occur also for links between an item and an article on the same wiki Hopefully with only a single repo & client required this should become a little easier as it should all be possible on a single wiki. > - We want to think of the testability of several Recent Changes entries while we write the tests (in case we are able to test dispatching in a single wiki) > > **Potential Plan of Action** > (1a) We can simply write a browser test (that would probably not be run locally) to ensure this behavior is correct > (1b) Alternately, we could potentially write it as API Integration tests to wait for jobs to complete while testing this behavior > > (2) Look into change propagation <https://wikitech.wikimedia.org/wiki/WMDE/Wikidata/Dispatching> [entry file here] and in particular how it relates to item deletion, we can track down the class that was mentioned in the description: `JobQueueChangeNotificationSender` to figure out where the call to `sendNotification` has gone to TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: ItamarWMDE, Michael, Lydia_Pintscher, WMDE-leszek, Jon.b.amar, Addshore, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, Susie413113, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
