Lucas_Werkmeister_WMDE added a comment.
What I’ve found in the code so far:
- `RepoHooks::onArticleDeleteComplete()` calls
`ChangeNotifier::notifyOnPageDeleted()`
- which calls `ChangeFactory::newForPageDeleted()` and transmits the
resulting change
- `RecentChangeSaveHookHandler::onRecentChange_save()` gets all the
transmitted changes and dispatches them if needed, **but:**
`onRecentChange_save()` only handles edits and page //restores//, not
deletions?
if ( $logType === null || ( $logType === 'delete' && $logAction ===
'restore' ) ) {
foreach ( $this->changeHolder->getChanges() as $change ) {
$this->handleChange( $change, $recentChange );
}
}
That looks like it would explain the issue – but that condition is almost
eight years old (Set Change timestamp based on RC timestamp
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/191649>), so
that doesn’t explain why this would be a regression with the new change
dispatching code…
TASK DETAIL
https://phabricator.wikimedia.org/T326082
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, ItamarWMDE, Michael, Lydia_Pintscher, WMDE-leszek,
Jon.b.amar, Addshore, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531,
Astuthiodit_1, Susie413113, 786, Biggs657, karapayneWMDE, Invadibot,
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696,
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci,
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345,
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton,
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
