Lucas_Werkmeister_WMDE added subscribers: DannyS712, Umherirrender. Lucas_Werkmeister_WMDE added a comment.
Just going to quote these two comments again… In T338452#8913695 <https://phabricator.wikimedia.org/T338452#8913695>, @Lucas_Werkmeister_WMDE wrote: > This should probably be a Wikibase ADR <https://doc.wikimedia.org/Wikibase/master/php/docs_adr_index.html>, though I’m not sure which team at WMDE is responsible for it (probably #wikibase_product_platform <https://phabricator.wikimedia.org/tag/wikibase_product_platform_team_wpp/>?). In T338452#9010056 <https://phabricator.wikimedia.org/T338452#9010056>, @gerritbot wrote: > Change 928175 **abandoned** by Umherirrender: > > [mediawiki/extensions/Wikibase@master] Expand/Create HookRunner classes and create hook handler interfaces > > Reason: > > Seems to need some architectural approval for this group of extension. Maybe better done in small patch sets once approved. > > https://gerrit.wikimedia.org/r/928175 I still think this task should have a decision by Wikibase developers. What the task //doesn’t// need is untested and broken patches (T347818 <https://phabricator.wikimedia.org/T347818>) that are uploaded on a Sunday evening and merged less than two hours later, thus ensuring that no WMDE developer can possibly review them in time. (The brokenness of the `MaintenanceShellStart` patch would’ve been quite easily testable by a developer who knew what the hook does – just pop open a maintenance shell.) TASK DETAIL https://phabricator.wikimedia.org/T338452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Umherirrender, DannyS712, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
