Umherirrender added a comment.
In T338452#8913695 <https://phabricator.wikimedia.org/T338452#8913695>, @Lucas_Werkmeister_WMDE wrote: > This should probably be a Wikibase ADR <https://doc.wikimedia.org/Wikibase/master/php/docs_adr_index.html>, though I’m not sure which team at WMDE is responsible for it (probably #wikibase_product_platform <https://phabricator.wikimedia.org/tag/wikibase_product_platform_team_wpp/>?). Does this apply to Wikibase only? Or also for other deployed extensions from the eco system? Extensions like: - ArticlePlaceholder (T346514 <https://phabricator.wikimedia.org/T346514>) - WikibaseCirrusSearch (T346518 <https://phabricator.wikimedia.org/T346518>) - WikibaseLexeme (T346516 <https://phabricator.wikimedia.org/T346516>) - WikibaseLexemeCirrusSearch (T346517 <https://phabricator.wikimedia.org/T346517>) - WikibaseMediaInfo (T338456 <https://phabricator.wikimedia.org/T338456>) - WikibaseQualityConstraints (T346519 <https://phabricator.wikimedia.org/T346519>) - WikimediaBadges (T346505 <https://phabricator.wikimedia.org/T346505>) In T338452#9214371 <https://phabricator.wikimedia.org/T338452#9214371>, @Lucas_Werkmeister_WMDE wrote: > I still think this task should have a decision by Wikibase developers. What the task //doesn’t// need is untested and broken patches (T347818 <https://phabricator.wikimedia.org/T347818>) that are uploaded on a Sunday evening and merged less than two hours later, thus ensuring that no WMDE developer can possibly review them in time. (The brokenness of the `MaintenanceShellStart` patch would’ve been quite easily testable by a developer who knew what the hook does – just pop open a maintenance shell.) Wikibase already uses `HookHandlers`, I was not aware that converting already-existing handlers to use this function is also covered by that. TASK DETAIL https://phabricator.wikimedia.org/T338452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, DannyS712, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
