Michael added a comment.

  In T345083#9363884 <https://phabricator.wikimedia.org/T345083#9363884>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > Hmph, `wb.getLanguageNameByCode` is also used for both term and non-term 
contexts (glosses in WikibaseLexeme), just like the PHP version, so I think 
we’ll have to do the same split there. Call it 
`wb.getLanguageNameByCodeForTerms`, I guess?
  
  Meh. But `wb.getLanguageNameByCodeForTerms` works, I agree.
  
  In T345083#9364107 <https://phabricator.wikimedia.org/T345083#9364107>, 
@Sarai-WMDE wrote:
  
  > In T345083#9364064 <https://phabricator.wikimedia.org/T345083#9364064>, 
@Lucas_Werkmeister_WMDE wrote:
  >
  >> Is “enter a label in default values (mul)” okay as the placeholder?
  >> F41543652: image.png <https://phabricator.wikimedia.org/F41543652>
  >
  > Definitely not great. It doesn't feel right to break the pattern, but maybe 
we could say "Enter a default label"? att: @Manuel
  
  Also, that placeholder currently defacto says "enter a label in multiple". 
(placeholders do not cause line breaks/ellipses, they're just cut off 
unceremoniously.)
  So "Enter a default label" is definitively an improvement and might even be 
short enough in English to be shown in full.
  
  And also the a11y aria-label doe for the mul-description in the Termbox might 
potentially benefit from some special handling.

TASK DETAIL
  https://phabricator.wikimedia.org/T345083

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Michael
Cc: Michael, Lucas_Werkmeister_WMDE, Epidosis, Amire80, Mahir256, Nikki, 
Lydia_Pintscher, Sarai-WMDE, ItamarWMDE, Aklapper, Manuel, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to