akosiaris added a comment.
In T355685#9490871 <https://phabricator.wikimedia.org/T355685#9490871>, @Lucas_Werkmeister_WMDE wrote: > Thanks a lot – I’ve added some of that information at https://wikitech.wikimedia.org/wiki/WMDE/Wikidata/SSR_Service#Deployment where it will hopefully be helpful in future. > > With your explanation, I think the `test` and `staging` releases are each somewhat useful (though I wouldn’t mind if you want to remove one of them either). Additionally, it sounds like it would be useful to make the `test` release in particular less special; I guess ideally, `values-test.yaml` would override the `config.public.WIKIBASE_REPO` (`test.wikidata.org` instead of `www.wikidata.org`) and the `main_app.version` (so we can bump this version before the `production` one), but almost nothing else? But to me that seems like a separate task. What do you think? Definitely different task. I am also not at all sure right now that the test release can easily be folded in like that, we 'll have to see if the service mesh is able to support >1 release being exposed like that. > Meanwhile, we should still fix the `localhost` issue of the `production` release. My understanding is that changing `localhost` to `127.0.0.1` might work, but T355686 <https://phabricator.wikimedia.org/T355686> has been proposed as an alternative solution that might be more sustainable; do you have any preference which one we should go for? T355686 <https://phabricator.wikimedia.org/T355686> is the preferable approach here, solving the problem more generically by having envoy dual stack binding and avoiding having every single application hardcoding localhost to 127.0.0.1. > (I was also wondering why the `HEALTHCHECK_QUERY` in `values.yaml`, which looks correct to me, didn’t prevent the broken deployment – but as far as I can tell, it’s not actually connected to any Kubernetes liveness/readiness/startup probes like I had assumed. It ends up in some OpenAPI spec `x-amples` (`curl 'https://staging.svc.eqiad.wmnet:4004/?spec'`) and that’s apparently all.) That thing is used by https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/service-checker/+/refs/heads/master which runs in our monitoring infrastructure. It utilizes the `x-amples` stanza to construct and issue queries to the service as part of monitoring, effectively mimicking a simple "user", at least as far as the x-amples stanzas for every endpoint instruct it to. TASK DETAIL https://phabricator.wikimedia.org/T355685 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: akosiaris Cc: Aklapper, akosiaris, Clement_Goubert, Jdforrester-WMF, Michael, WMDE-leszek, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Kappakayala, Mohamed-Awnallah, Astuthiodit_1, lbowmaker, Arnoldokoth, BTullis, karapayneWMDE, Invadibot, Ywats0ns, maantietaja, wkandek, JMeybohm, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, jijiki, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
