Lucas_Werkmeister_WMDE added a comment.
In T355685#9490969 <https://phabricator.wikimedia.org/T355685#9490969>, @akosiaris wrote: > Definitely different task. I am also not at all sure right now that the test release can easily be folded in like that, we 'll have to see if the service mesh is able to support >1 release being exposed like that. Created T355955: Simplify Termbox SSR test release <https://phabricator.wikimedia.org/T355955>. >> Meanwhile, we should still fix the `localhost` issue of the `production` release. My understanding is that changing `localhost` to `127.0.0.1` might work, but T355686 <https://phabricator.wikimedia.org/T355686> has been proposed as an alternative solution that might be more sustainable; do you have any preference which one we should go for? > > T355686 <https://phabricator.wikimedia.org/T355686> is the preferable approach here, solving the problem more generically by having envoy dual stack binding and avoiding having every single application hardcoding localhost to 127.0.0.1. Alright, then let’s see how that task develops. I’ve set myself a calendar reminder to come back to this task in ~two weeks, because I don’t think we should have a known broken version tagged as `latest` indefinitely – if the general solution doesn’t happen soon, we should either hard-code `127.0.0.1` after all (we can always revert it later) or revert the Node 18 upgrade for now. (But that’s not meant to hurry or pressure T355686 <https://phabricator.wikimedia.org/T355686> at all, I just want to make sure we don’t forget about the Wikidata part :)) >> (I was also wondering why the `HEALTHCHECK_QUERY` in `values.yaml`, which looks correct to me, didn’t prevent the broken deployment – but as far as I can tell, it’s not actually connected to any Kubernetes liveness/readiness/startup probes like I had assumed. It ends up in some OpenAPI spec `x-amples` (`curl 'https://staging.svc.eqiad.wmnet:4004/?spec'`) and that’s apparently all.) > > That thing is used by https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/service-checker/+/refs/heads/master which runs in our monitoring infrastructure. It utilizes the `x-amples` stanza to construct and issue queries to the service as part of monitoring, effectively mimicking a simple "user", at least as far as the x-amples stanzas for every endpoint instruct it to. I see, thanks. So it the broken termbox would’ve shown up in monitoring sooner or later even without me testing it, but it didn’t automatically hold back the new version. TASK DETAIL https://phabricator.wikimedia.org/T355685 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, akosiaris, Clement_Goubert, Jdforrester-WMF, Michael, WMDE-leszek, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Kappakayala, Mohamed-Awnallah, Astuthiodit_1, lbowmaker, Arnoldokoth, BTullis, karapayneWMDE, Invadibot, Ywats0ns, maantietaja, wkandek, JMeybohm, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, jijiki, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
