ArthurTaylor added a comment.
I've added a patch / proposed a fix for issue 1. Issue 2 I think is not a real problem with the OOUI styles. In the OOUI demo, the margin around the text is normally 5px: F42746355: ooui-popup-1.png <https://phabricator.wikimedia.org/F42746355> In the example pop-ups, there is an additional bottom-margin of 8px, which the ticket asks that we preserve. F42746356: ooui-popup-2.png <https://phabricator.wikimedia.org/F42746356> But on closer inspection, this 8px margin comes from the demo stylesheet (`demo.css`), and I'm not sure we should consider that canonical (or we need to add that ourselves to our dialogs): F42746357: ooui-popup-3.png <https://phabricator.wikimedia.org/F42746357> The expected 5px margin is present in the pop-up as it appears currently in production. The spacing looks a bit narrow because the checkbox occupies the entire line height, but there are 5 pixels between the bottom of the checkbox and the border of the pop-up: F42746358: ooui-popup-4.png <https://phabricator.wikimedia.org/F42746358> TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor Cc: Manuel, CCiufo-WMF, Lucas_Werkmeister_WMDE, Michael, Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, NBaca-WMF, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, xSavitar, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Gryllida, Ricordisamoa, Jdforrester-WMF, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
