Sarai-WMDE added a comment.
@ArthurTaylor thanks for the fix and for sharing the clear findings! That's totally right, the actual default margin of the OOUI popover is 5px. I would consider 8px to be more canonical, given that the base spacing unit of our systems (both OOUI and Codex) are 8/16px. My assumption is that a smaller margin was applied to avoid excessive spacing in certain situations? In the wild, these popovers have generally a compounded spacing that's greater than 5px. Here are a couple of examples from the Wikipedia's visual editor: | F42749711: Screenshot 2024-03-19 at 12.49.00.png <https://phabricator.wikimedia.org/F42749711> | F42750137: Screenshot 2024-03-19 at 13.10.02.png <https://phabricator.wikimedia.org/F42750137> | | So based on those examples, and the fact that the 5px margin looks quite narrow in our particular case due to the presence of the checkbox, I would encourage us to do whatever sounds easier: either use a 8px bottom margin, or apply a 0.25em bottom padding to the checkbox (the final exact value is not as important as creating visual balance around the content). Let me know if that sounds good! TASK DETAIL https://phabricator.wikimedia.org/T355059 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Sarai-WMDE Cc: Manuel, CCiufo-WMF, Lucas_Werkmeister_WMDE, Michael, Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, NBaca-WMF, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, xSavitar, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Gryllida, Ricordisamoa, Jdforrester-WMF, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
