Sarai-WMDE added a comment.

  Agreed, with the UI looking good and with the needed copy fix. I can't 
reproduce the message padding issues, though. Could it be related to font size 
or family?
  I detected some further adjustments needed to follow the original specs. 
Please let me know if there's anything mentioned that's actually not feasible:
  | Change                                                                      
   | Current                                                                    
                                             | Specified                        
  | 1. Fix vertical padding around and between the run and cancel buttons       
   | F42748831: Screenshot 2024-03-19 at 12.04.07.png 
    | All noted spacing should be 0.5rem. (Maybe we could use our custom 
spacing variables?)                                         |
  | 2. The default size of large Codex buttons shouldn't be overridden          
   | F42748910: Screenshot 2024-03-19 at 12.08.34.png 
    | The buttons should display a size of 44x44px                              
  | 3. Aria-labels are not accessible                                           
   | When the Run and Cancel buttons are focuses, VoiceOver reads the literal 
aria-labels content ("wdqs-app-button-run-aria-label" and 
"wdqs-app-button-cancel-aria-label") instead of the intended message | The 
correct message should be provided via these aria labels to users of assistive 
technology                                  |
  | 4. Fix copy of Cancel button's `title`                                      
   | `title="Stop query (CTRL + ESC)"`                                          
                                             | The action should be "cancel" 
instead of "stop". The message would read:  "Cancel query (CTRL+ESC)"           
  | 5. Make it possible to cancel queries using the "CTRL + ESC" keyboard 
shortcut | While a query is being executed, pressing the key combination "CTRL 
+ ESC" has no effect                                                            
                                                    | Pressing "CTRL + ESC" 
should have the same effect as pressing the Cancel button:  the query should 
stop from running in the UI |
  The last point (5) wasn't actually made explicit in this ticket, so it'd be 
understandable if the team preferred to create a subtask to implement that.



To: HasanAkgun_WMDE, Sarai-WMDE
Cc: noarave, guergana.tzatchkova, HasanAkgun_WMDE, dcausse, Gehel, Michael, 
Ainali, Lydia_Pintscher, jhsoby, agray, Nikki, Sarai-WMDE, Arian_Bozorg, 
edwardbetts, Aklapper, Bugreporter, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 
AWesterinen, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Namenlos314, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, Lucas_Werkmeister_WMDE, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, KimKelting, merbst, LawExplorer, Salgo60, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
Wikidata-bugs mailing list --
To unsubscribe send an email to

Reply via email to