JanZerebecki added a comment. Copying from https://gerrit.wikimedia.org/r/#/c/234291/ : Daniel Kinzler:
> I'd prefer something that is less ad-hoc than this. Perhaps we could use > Symfony's CSS selector implementation > http://symfony.com/doc/current/components/css_selector.html (and skip the > test if the component is missing). > > But I agree with Thiemo that we should rather replace assertTag with simple > assertContains and *simply* assertRegex calls, where possible. Ricordisamoa: > How are regular expressions not ad-hoc? Are you sure it's really worth it to > use complicated and fragile patterns that must take into account the order of > attributes, nested nodes, different quote styles etc. whereas with a few > dozens of LOCs you can leverage a real (X|HT)ML parser using a syntax that is > both clear and extensible as seen in SpecialModifyTermTestCase? TASK DETAIL https://phabricator.wikimedia.org/T69122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: JanZerebecki, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Bene, Tobi_WMDE_SW, JeroenDeDauw, adrianheine, Lydia_Pintscher, daniel, aude _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
