Ricordisamoa added a comment. In https://phabricator.wikimedia.org/T69122#1701960, @daniel wrote:
> - DOMTestUtils would be "born deprecated". We don't want to encourage more > usages of it, we really want it to go away and be replaced with something > better DOMTestUtils is not in good shape yet, but eventually it should implement a sensible subset of `assertTag()` and be quite stable. > based on CSS selectors, perhaps I'm not aware of any CSS equivalent of 'content'. > - DOMTestUtils is currently copied around. It would make more sense to put > assertTagSimple() into the phpunit-dom-assertions project, which has support > for assertTag as a TODO. Or at least put it into MediaWikiTestCase. Sure. > If we //urgently// need to migrate to a PHPUnit 5, I'd agree to using > assertTagSimple() for now. But it seems that there are several more blockers > to this, which gives us time to work on The Real Solution. That's why I opposed https://gerrit.wikimedia.org/r/237372 in the first place. > PS: Is it correct that the code in DOMTestUtils was mainly copied from > PHPUnit? If so, it needs to attribute Sebastian Bergman to be in compliance > with the BSD license: //"Redistributions of source code must retain the above > copyright notice, this list of conditions and the following disclaimer."// Have a look at https://github.com/sebastianbergmann/phpunit/blob/9a0ed21d58b263ea1e32f8d2e6151f56dac088e2/PHPUnit/Util/XML.php#L515 and https://gerrit.wikimedia.org/r/#/c/234291/7/repo/tests/phpunit/includes/DOMTestUtils.php TASK DETAIL https://phabricator.wikimedia.org/T69122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ricordisamoa Cc: JanZerebecki, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Bene, Tobi_WMDE_SW, JeroenDeDauw, adrianheine, Lydia_Pintscher, daniel, aude _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
