thiemowmde added a comment.

What's wrong with `StatementSectionView` (singular, because it's for one 
section only), as already suggested? I suggest to simply stick to that.

The interface can be a general `StatementGrouper`, sure. If it's designed in a 
way that it could also support "group by property id" in the future, I do not 
have a problem with that.

> (basically a hash map from propertyId to StatementList)


Isn't this, the "group statements by property id" part, a solved problem?

> Another approach would be to ditch wbEntity, just follow the structure of the 
> DOM


I would not like this for one reason: It will then be impossible (or at least 
much harder) to have statements in the JS view that are not in the PHP view 
(for example, deprecated statements could be hidden behind a "more" button).


TASK DETAIL
  https://phabricator.wikimedia.org/T117421

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: Lydia_Pintscher, Aklapper, Sjoerddebruin, Liuxinyu970226, Ltrlg, 
Daniel_Mietchen, Ricordisamoa, Legoktm, Pigsonthewing, Filceolaire, PKM, Laddo, 
Sannita, Addshore, Multichill, Bene, Tobi_WMDE_SW, Snaterlicious, thiemowmde, 
adrianheine, Micru, jayvdb, MGChecker, DSGalaktos, Agabi10, Zolo, 
Wikidata-bugs, aude, Mbch331



_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to