adrianheine added a comment. After looking at https://gerrit.wikimedia.org/r/#/c/253912, I had the following thought:
I'm a bit unsure about the names and where the section title is rendered. In PHP, that's all pretty simple, but I would like PHP and JS to be consistent, and in JS things will be not so trivial. In JS, an entityview will have a statementsectionsview which gets the whole statements dom and all the statements (currently a StatementGroupSet) from the entity. We could also call this view `statementsview`, since it does not matter to the entityview whether the statements are in sections or whatever. To the entityview, it's just the view handling the statements. I think I would like that. The statementsview would group the statements and pass each (section) group to a statementsectionview, which would have the heading and a statementgrouplistview. All the `statementsectionview`s would be in a listview. With that approach, `StatementSectionsView` should indeed be called `StatementSectionView`, and get only one section (key and statements) per `getHtml` call. I would then like to have a `StatementsView` in PHP, too, though. That `StatementsView` would do the grouping that's currently done in both `ItemView` and `PropertyView` and call out to the `StatementSectionView`. TASK DETAIL https://phabricator.wikimedia.org/T117421 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Lydia_Pintscher, Aklapper, Sjoerddebruin, Liuxinyu970226, Ltrlg, Daniel_Mietchen, Ricordisamoa, Legoktm, Pigsonthewing, Filceolaire, PKM, Laddo, Sannita, Addshore, Multichill, Bene, Tobi_WMDE_SW, Snaterlicious, thiemowmde, adrianheine, Micru, jayvdb, MGChecker, DSGalaktos, Agabi10, Zolo, Wikidata-bugs, aude, Mbch331 _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
