| WMDE-leszek added a comment. |
@Jakob_WMDE sorry, somehow I've managed to miss your comment.
One concern that I had while working on this was that the keys of the returned arrays of getAllPropertyInfo and getPropertyInfoForDataType of the previous implementations of PropertyInfoStore are numeric IDs of properties. Is that something that would need to be addressed (right away)?
Good point, I haven't realized that while first looking at your patch. I don't know if this should be done right away (as in in the patch adding DispatchingPropertyInfoLookup) but this should be probably be done rather soon. As I get, what the dispatching would currently do would be overriding properties from one repo if the property from the other repo happens to have the same number part of id. This is quite bad.
One option could be to index those result arrays with id serialization (including repo prefix) instead of just using numeric keys. I had a brief look on usage of getAllPropertyInfo and getPropertyInfoForDataType and if I am not mistaken it such change should be not that complicated. I am not sure how sorting should be applied (in Special:ListProperties) but this is definitely something we could figure out.
Cc: WMDE-leszek, daniel, gerritbot, Aklapper, Jakob_WMDE, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
