| daniel added a comment. |
@Jakob_WMDE Good catch!
I agree with @WMDE-leszek that we should switch to full serialized IDs instead of numeric IDs for the array index. That should not be done in the same patch, but perhaps it should be done before the patch introducing the dispatching implementation. Doing it after is still OK because we will not have properties from multiple repos at once any time soon, btu we should still address this quickly.
As Leszek said, it doesn't look like it would be hard to fix.
A word about Special:ListProperties, though: I'm not sure whether it should list all available properties, or just the ones from the local repo. Or maybe there should be an option for selecting the repo (or all repos)? I suppose we need to think about the use cases for that special page again.
If we show properties from multiple different repos on Special:ListProperties, it would be nice if we could sort by repo first, and then by numeric ID second. Sorting by the serialized ID would be bad - if we can't sort by numeric ID, we should sort by name.
Btw, note that Special:ListProperties is the only actual use of getPropertiesByType. We could remove that from the service interface, and just filter directly in the special page implementation. Even with properties from multiple repos, we can (and do) still assume that we will have no more than a few thousand properties, and can easily handle them all at once in memory.
Cc: WMDE-leszek, daniel, gerritbot, Aklapper, Jakob_WMDE, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
