| daniel added a comment. |
In T171607#3478233, @Lucas_Werkmeister_WMDE wrote:As far as I can tell, we’ll need hashes in the output of wbeditentity if we want to have those hashes in the DOM (T171725). Or can the _javascript_ view calculate the hashes?
No, the frontend code should not do its own hash calculations. That's going to fail horribly. The has is not based on the JSON representation.
When does the frontend code need to build a DOM fragment from JSON? After an edit completes, I assume. II still think it would save us a ton of trouble to simply ask the backend to do that, instead of doing it in JS... oh well.
If we need that, hashes should be optional in the output of all API modules (and off per default).
TASK DETAIL
EMAIL PREFERENCES
To: daniel
Cc: Addshore, Aklapper, daniel, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331
Cc: Addshore, Aklapper, daniel, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
