[Wikidata-bugs] [Maniphest] [Commented On] T171607: Main snak and reference snaks do not include hash in JSON output

Thu, 27 Jul 2017 07:14:34 -0700

daniel added a comment.

The following places currently construct statement serializers:

  • Scribunto_LuaWikibaseLibrary::newEntityAccessor()
  • WikibaseRepo::getApiHelperFactory()
  • SpecialEntityData::newDefaultRequestHandler()
  • DumpJson::execute()

All of them, set use the OPTION_SERIALIZE_MAIN_SNAKS_WITHOUT_HASH and OPTION_SERIALIZE_REFERENCE_SNAKS_WITHOUT_HASH flags. None of them sets the OPTION_SERIALIZE_QUALIFIER_SNAKS_WITHOUT_HASH.

I cannot remember any good reason for this. I suspect that the flags were simply copied around. Perhaps the OPTION_SERIALIZE_QUALIFIER_SNAKS_WITHOUT_HASH mode was added later.


TASK DETAIL
https://phabricator.wikimedia.org/T171607

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: Addshore, Aklapper, daniel, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to