Krinkle added a comment. |
In T173696#3569491, @Ladsgroup wrote:
I left a few minor points at https://gerrit.wikimedia.org/r/373918.
I don't know much about the use of regular expressions in the particular context of Sparql and Wikidata, but it does leave me somewhat confused. If the regex itself was retrieved from the wiki database (not Sparql) and the input text is available in PHP, why do we need to query an external service to execute a regular _expression_?
TASK DETAIL
EMAIL PREFERENCES
To: Krinkle
Cc: Krinkle, aaron, gerritbot, Ladsgroup, daniel, Aklapper, Jonas, Lucas_Werkmeister_WMDE, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Agabi10, Izno, Wikidata-bugs, aude, Mbch331
Cc: Krinkle, aaron, gerritbot, Ladsgroup, daniel, Aklapper, Jonas, Lucas_Werkmeister_WMDE, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Agabi10, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs