dcausse added a comment.

Right now the field name is statements. I'm not sure whether we should add wb there (everything in that index is "wb", since it's on wikidata). What do you mean by "typed" though?

I mean a name that bears the data types it stores, for me "statements" seems too generic, if for now you index "instance of" you'll have values of data types "item", now if you decide to add P1559 (monolingual text) we should not index it in the "statements" elastic field they'll require totally different analyzers (one is an identifier, the other is written language).
It's why I'd prefer to name elastic fields based on the data type the property is using so why not item_statements instead of statements?


TASK DETAIL
https://phabricator.wikimedia.org/T175199

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev, dcausse
Cc: aude, gerritbot, debt, EBernhardson, dcausse, daniel, Aklapper, Smalyshev, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to