Hello,
On Fri, Jun 19, 2009 at 20:31, Rolf Lampa <[email protected]> wrote:
> Jaska Zedlik skrev:
> <...>
> > The code of the override function is the following:
> >
> > function stripForSearch( $string ) {
> > $s = $string;
> > $s = preg_replace( '/\xe2\x80\x99/', '\'', $s );
> > return parent::stripForSearch( $s );
> > }
>
> I'm not a PHP programmer, but why using the extra assignment of $s
> instead of using $string directly in the parent call, like so:
>
> function stripForSearch( $string ) {
> $s = preg_replace( '/\xe2\x80\x99/', '\'', $string );
> return parent::stripForSearch( $s );
> }
>
Really, you are right, for the real function all these redundant assignments
should be strepped for the productivity purposes, I just used a framework
from the Japanese language class which does soma Japanese-specific
reduction, but I agree with your notice.
zedlik
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
