Hey, > From the looks of the code, Validator, and various Validator based extensions appear to be using parser->parse() inside of hooks where they are supposed to be using ->recursiveTagParse with a proper frame.
I was not aware of the correct approach here apparently. I had a look at the docs and hope I got it right now. > The Validator extension's api appears to provoke this bad practice because I don't see the frame in the arguments render methods are using. Now all info you need to handle parser functions and tag extensions separately is available in the render method. I also added a small utility function meant to abstract the difference, for people that like me do not want to have to care about if the call is coming from a tag or function. Changes: * https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/81218 * https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/81219 Does this address the issue correctly? Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. -- _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
