I was planning on emailing him a patch, probably after I wrote some tests to ensure I wasn't submitting him something with issues.
- Trevor On Feb 1, 2011, at 1:41 PM, Platonides wrote: > Trevor Parscal wrote: >> There are 2 components to the JavaScriptDistiller library. One of them (the >> ParseMaster class) is 100% in sync with the official distribution. The other >> (the JavaScriptDistiller class) was originally based on the >> JavaScriptPacker::_basicCompression function. That function had some issues >> that we have worked out, and in the process of doing that we've gotten >> really far away from the original source. It appears that our version is >> just about stable, so I plan to offer the code in JavaScriptDistiller to the >> JavaScriptPacker author to try and help make his library better as well. >> >> In the former case, any changes should be strictly passed upstream. In the >> latter case, I think we should offer them upstream but realize that we have >> deviated from the original author's structure and possibly intentions enough >> that they may or may not be wanted. >> >> - Trevor > > How should they be sent upstream? I did for instance a small change at > r81207, but given that we don't have any tests, decided to wait before > annoying the upstream author (I think that would be Nicolas?). > I don't see a repository there, so we could as well offer him space for > it in our hierarchy. > > > _______________________________________________ > Wikitech-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/wikitech-l _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
