2011/2/13 MZMcBride <[email protected]>: > For example, Meta-Wiki was returning completely blank pages due to the use > of document.write() on pages that contained a particular CSS class. If > document.write() is completely disallowed, it should be noted somewhere > prominently along with other problematic or possibly problematic bits of > code. I briefly checked http://www.mediawiki.org/wiki/ResourceLoader but > didn't see this kind of list off-hand. > document.write() is risky and usually evil, and should not be used unless you know exactly what you're doing. Specifically, ResourceLoader itself uses document.write() in one case, and checks that it's safe before it calls it. In scripts loaded by RL, using document.write() is almost always if not always unsafe. You're right that we should probably list this, but I'd forgotten about this subtlety.
Roan Kattouw (Catrope) _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
