Roan Kattouw <[email protected]> writes: > We should definitely do this, and de facto we do this already. This is > what I meant by reassigning as appropriate. However, I think it's a > good idea to balance "everything else" over all reviewers, even the > specialized ones.
Sure. And specialized reviewers should not be seen as the *only* people who can review code in a particular area. We need cross-pollination and restricting code review access to only specialists does not help this. > I was thinking that tying things to certain days would enforce > regularity more naturally than per-directory review would. I'm sure different people have different ways of working and it won't be till we've field-tested this stuff that we'll really know what is best. The focus now should be on getting regular reviews — keeping the 1.18 branch in close sync with trunk — not on pushing this or that way of doing things. >> Side note: I'd like to encourage code reviewers to see this as an >> opportunity to work with less experienced developers. > > Yes, I wrote the CodeReview sign-off feature with this in mind. Excellent, I haven't had a chance to look at sign-off yet, so this is good news. Mark. _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
