2011/2/13 Mark A. Hershberger <[email protected]>: > Right. And while I think your suggestion of assigning 7 developers a > day to do reviews could work, what if we divide the code into different > areas? From looking at the sub-directories under includes/ I would > suggest a different person assigned to API, Parser, Uploads, DB, > Installer, ResourceLoader, Templates, Specials, and probably a couple > assigned to “Everything Else”. > We should definitely do this, and de facto we do this already. This is what I meant by reassigning as appropriate. However, I think it's a good idea to balance "everything else" over all reviewers, even the specialized ones.
> The advantage to this, instead of having everyone manage certain days is > that it becomes a smaller, semi-daily activity instead of a larger, > once-a-week activity. My hope is that this would be more likely to get > done on a regular basis. > I was thinking that tying things to certain days would enforce regularity more naturally than per-directory review would. > Side note: I'd like to encourage code reviewers to see this as an > opportunity to work with less experienced developers. We've burdened > some of our most knowledgeable and productive developers with code > review. At least some of this work could be shifted to less experienced > developers. More on that in a bit. > Yes, I wrote the CodeReview sign-off feature with this in mind. Roan Kattouw (Catrope) _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
