User "IAlex" changed the status of MediaWiki.r86041.

Old Status: new
New Status: fixme

User "IAlex" also posted a comment on MediaWiki.r86041.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86041#c15948
Commit summary:

r86001, now with less scariness :P  I took out the delete action and did purge 
instead, which is a much more self-contained action-with-a-form.  Also 
implement a few changes suggested by Brion on IRC last night.

Comment:

* This broke inline credits: <b>Fatal error</b>:  Class 'Credits' not found in 
<b>includes/SkinTemplate.php</b> on line <b>385</b> (there's a similar call in 
SkinLegacy)
* Action class is missing an accessor for the user language object (i.e. 
replacement of $wgLang)
* Asking people to ''not use globals $wgOut, $wgRequest, etc'' and in the 
meantime using wfMessage() or other wfMsg*() functions is inconsistent, since 
wfMessage() is depending on $wgLang, $wgOut and $wgTitle (depending on how your 
are using it).

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to