User "Bawolff" changed the status of MediaWiki.r86041. Old Status: new New Status: fixme
User "Bawolff" also posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c15973 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night. Comment: This does look much nicer :) Unfortunately it breaks action=purge, because it tries to redirect to $this->getTitle() instead of $this->getTitle()->getFullUrl() (works sometimes due to relative url, but breaks horribly if the page is not in main namespace since colon is un-escaped, or if person is not using short urls, etc). Also we'd probably want to preserve the query parameters there (except possibly the action=purge parameter) if for example someone was purging a category with the frompage=foo parameter, etc. I'm not really sure if there's actually much benefit of redirecting after the purge... _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
