User "Catrope" changed the status of MediaWiki.r86603. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r86603. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86603#c16200 Commit summary: Move edit.js stuff to mediawiki.action.edit.js, and remove wikibits dependency. Wrap publicly accessible functions inside mw.toolbar & provide legacy shortcuts to those. Make the traditional toolbar use $.fn.textSelection, to reduce code duplication. This fixes Bug 27116, Bug 15705, Bug 11011 Comment: <pre> + for ( i = 0; i < window.mwCustomEditButtons.length; i++ ) { </pre> <code>i</code> is leaked into the global scope. Use <code>for ( var i = 0; ....</code> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
