User "Platonides" posted a comment on MediaWiki.r88177.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88177#c16975
Commit summary:

Fix for HipHop breakage in r87748 etc. Please do not use 
require_once(dirname(__FILE__)...) to fetch class, function or define() 
dependencies anymore. You do not need to have HipHop to know that doing so will 
break it.

Comment:

Didn't the 'if ( !defined( 'MW_COMPILED' ) )' work to avoid it for HipHop?

It's not nice that you now have some functions missing despite including 
GlobalFunctions.php



_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to