User "Tim Starling" posted a comment on MediaWiki.r88177. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88177#c17313 Commit summary:
Fix for HipHop breakage in r87748 etc. Please do not use require_once(dirname(__FILE__)...) to fetch class, function or define() dependencies anymore. You do not need to have HipHop to know that doing so will break it. Comment: The thing that broke HipHop was the <pre>require_once dirname(__FILE__).'/UtfNormalDefines.php';</pre> in UtfNormalUtil.php. This revision didn't fix it properly, you also need the Setup.php change in r88959. Including GlobalFunctions.php has never been a way to get all global functions. UtfNormalUtil.php was only there for historical reasons. If you want all functions, you should include either WebStart.php or Maintenance.php. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
