User "Hashar" changed the status of MediaWiki.r88276. Old Status: new New Status: ok
User "Hashar" also posted a comment on MediaWiki.r88276. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88276#c17076 Commit summary: mw.util.getActionFrom incorrectly returns null * Return 'view' for urls like: - /w/index.php?title=Foobar * Anything else, fallback to 'view' (just like PHP does) * JSHint - ['view'] is better written in dot notation. - 'action' was already defined on line 235. - 'actionRe' is defined multiple times (loop). - Use '===' to compare with '0'. - 'title' is already defined. >> The code check passed 100%! * Adding QUnit test for getActionFrom and getTitleFrom (Follow-up r87964) Comment: Thanks for the default settings. I have reviewed the tests :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
