User "Brion VIBBER" changed the status of MediaWiki.r88276. Old Status: ok New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r88276. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88276#c17116 Commit summary: mw.util.getActionFrom incorrectly returns null * Return 'view' for urls like: - /w/index.php?title=Foobar * Anything else, fallback to 'view' (just like PHP does) * JSHint - ['view'] is better written in dot notation. - 'action' was already defined on line 235. - 'actionRe' is defined multiple times (loop). - Use '===' to compare with '0'. - 'title' is already defined. >> The code check passed 100%! * Adding QUnit test for getActionFrom and getTitleFrom (Follow-up r87964) Comment: There seem to be some bogus changes in here, for starters: * getTitleFrom is now documented to return either a Title object or null, whereas it seems to return a *string* or null. * getActionFrom is now documented to return an Action object, but it also looks like it returns a string. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
