User "MaxSem" posted a comment on MediaWiki.r89409. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89409#c17535 Commit summary:
* suggestion for using tables.sql parsing instead of database query for tables list needed for phpunit * would be better option IMO since the database is not necesserally dedicated to MW install Comment: This is a huge overcomplication for a superficial reason. For databases shared between MW and third-party apps there is database prefix - those who chose not to use it are already doomed for reasons unrelated to unit tests. Besides, nobody runs tests on production systems where we can expect shared databases. In any case, a fixme is warranted because some extensions '''already''' use both tests and extra tables (example: FlaggedRevs). They are broken or may be broken at any moment they may want to access database during tests. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
