User "^demon" posted a comment on MediaWiki.r89409. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89409#c17539 Commit summary:
* suggestion for using tables.sql parsing instead of database query for tables list needed for phpunit * would be better option IMO since the database is not necesserally dedicated to MW install Comment: Don't see why we need a new hook, we should be able to make use of LoadExtensionSchemaUpdates here. I also disagree with your statement MaxSem that "people not using prefixes are doomed to failure" Lets say you don't use a prefix on your tables, MediaWiki is in a DB *by itself.* You ran the unit tests (not with temporary tables, as I was day before yesterday to confirm some stuff). Subsequent runs would also duplicate your unittest_ tables. Edge case, sure...but checking tables.sql (and using our already-available-hook) prevents that and has us only duplicating tables we need. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
