User "Reedy" posted a comment on MediaWiki.r87292.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87292#c17786
Commit summary:

* (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded

Severly limit the number of calls that actually update the database (for no 
gain!). Leaving stuff that needs to update memcached

Still, there's probably quite a lot of these calls which are still superfluous

Comment:

For the stats, I've got no way of replicating this locally, so it's just a 
guess based on the fact "it's being called too often".

We'd need to run some more up to date stats, push it out, and see where we get 
to then post the changes

As it's only pushing an updated timestamp, it shouldn't have any negative side 
effects...

And it means whether we try and update the database user_touched field

<source lang="php">
                        $dbw->update( 'user',
                                array( 'user_touched' => $dbw->timestamp( 
$this->mTouched ) ),
                                array( 'user_id' => $this->mId ),
                                __METHOD__ );
</source>

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to