User "Brion VIBBER" posted a comment on MediaWiki.r87292. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87292#c17795 Commit summary:
* (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded Severly limit the number of calls that actually update the database (for no gain!). Leaving stuff that needs to update memcached Still, there's probably quite a lot of these calls which are still superfluous Comment: Well it's not called '''arbitrarily''', it's called '''in order to invalidate some cached data'''. If it's being called multiple times in the course of a larger operation, that probably indicates that the larger operation needs to be viewed as a whole and refactored to work more efficiently. Just jumping around and disabling parts of the cache invalidation willy-nilly sounds a bit dangerous and will probably just make maintenance much more confusing. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
