User "P.Copp" posted a comment on MediaWiki.r89648. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89648#c17800 Commit summary:
Another try at fixing bug 93 "tilde signatures inside nowiki tags sometimes get expanded (<includeonly><nowiki>~~~~</nowiki></includeonly>)" * Change the preprocessor to insert strip items for <ignore> nodes during pre-save-transform, just like <comment> nodes are handled already. This effectively disables all pre-save-transform steps inside <includeonly> tags. * Adapt parser tests to the new behavior. Comment: Actually it disables PST on ''includeonly'' sections which was intentional. I mentioned it in the commit summary but perhaps I wasn't clear enough. I proposed this change on the linked bug [https://bugzilla.wikimedia.org/show_bug.cgi?id=93#c19 in November 2009] and still think this would be the right approach. At the moment many templates use hacks like <pre>~~<includeonly></includeonly>~~</pre> to include signatures in substed templates without expanding them right on the spot. With the proposed change you could simply write <pre><includeonly>~~~~</includeonly></pre> Please do also note, that unlike r88997 this change won't break any existing page, because it doesn't expand anything that wasn't expanded before. As for the parser tests: There was only one test, that had to be changed and it was only introduced in r89191. So, if there are any objections to the proposed behavior I'd like to hear them :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
