User "P.Copp" posted a comment on MediaWiki.r87326.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87326#c17801
Commit summary:
Fix Bug 28354: Edit tab is shown as "view source" for blocked users, which
breaks squid caching
* Skip user block checks for Title::quickUserCan(). This restores the behavior
from 1.16 rsp. before r65504.
* Remove unnecessary check for "$short && count($errors)", this is already
handled by getUserPermissionsErrorsInternal().
Comment:
Yes, I just removed the check as it is duplicated in
Title::getUserPermissionsErrorsInternal():
<pre>
while( count( $checks ) > 0 &&
!( $short && count( $errors ) > 0 ) ) {
$method = array_shift( $checks );
$errors = $this->$method( $action, $user,
$errors, $doExpensiveQueries, $short );
}
</pre>
The parameter $short is merely a residue of the refactoring of r65504 and could
be removed from most of these functions.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
