User "Krinkle" posted a comment on MediaWiki.r89950. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89950#c18173 Commit summary:
do not sent api requests for empty inputs, e.g. after a character input followed by a backspace in the search input. Make sure to clear the result div to wipe previous results at the client w/o sending a request. Lowers server load Comment: It saves once click when the intention is to focus it, it costs an extra click to get back to the editor and or other input fields on the page. In the case described in the previous reply it costed a few extra key strokes as well. The student was editing a page while moving/pushing the mouse towards the right. As a result part of the text was written in the search field and http requests were made for search suggestions. Although I agree it looks cool when showing off (saving a click), I think in general the majority of our readers will not expect this and may be confused by it. To be consistent, perhaps it should unfocus (<code>blur()</code>) on <tt>mouseleave</tt> ? Don't get me wrong though, I'm not saying this is a bad idea, merely saying that in my opinion it's too big of a change to just push in SVN as the new default that was committed as "minor detail" commited together with something else. It should be discussed further, perhaps cross-linked with Trevor and/or someone else from the Usability Initiative. Hence better tracked in BugZilla as a feature request. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
