User "Wikinaut" posted a comment on MediaWiki.r89950.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89950#c18189
Commit summary:

do not sent api requests for empty inputs, e.g. after a character input 
followed by a backspace in the search input. Make sure to clear the result div 
to wipe previous results at the client w/o sending a request. Lowers server load

Comment:

I would like to give this "closing" statement:

I use this technique in all of my (about hundred) software gadgets - not 
necessarily wikis, because with jQuery it costs nothing. _My_ users are very 
happy with this technique. 

Please allow me to suggest this:

0. I admit, the the UI changed, but as mentioned: less clicks, if all elements 
get the focus automatically, including the body.
1. I ask you to leave the focus (here) as I coded it here ( r89950 ) for a 
while.
2. I open a bugzilla in the following days with a broader scope, i.e. to make 
_all_ relevant page elements auto-fetch the focus on hover, (also on click of 
course), and I will supply you with a mockup wiki running trunk having this 
technique for testing.
3. after having tested this mockup for you all, I will either commit this as a 
master change to all modules, or revert my single patch here for the search 
field.
4. deadline for end of tests: 30.06.2011

Tom



_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to