User "Krinkle" posted a comment on MediaWiki.r70498. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70498#c18973 Commit summary:
Change quickUserCan( 'edit' ) and getIsPrintable() into setEditSection( false ) Follow up r48544. Init ParserOptions::mIsPrintable in initialiseFromUser() Move the "No edit section it's printable" from Parser to Article. This leaves getIsPrintable() unused. Left there for extensions (none seems to be using it, could be removed). The "even if the user has them on" comment wasn't accurate. The user preference only controls them via CSS. Anyway, it would work as expected now if it got moved into ParserOptions. The setEditSection() no longer set it to true. Remove the quickUserCan( 'edit' ) which is just a hidden way of calling $wgUser from the Parser to be explicitely done in Article to disable the editsection. This results in quickUserCan being called once instead of twice if $wgUseETag == true;. Comment: *bump* this is still happening all SpecialPages in 1.17 with headings such as [[Special:Code/MediaWiki/status]] and delete/undelete block/unblock pages for the log headings. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
