User "Bawolff" posted a comment on MediaWiki.r70498.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70498#c19070
Commit summary:

Change quickUserCan( 'edit' ) and getIsPrintable() into setEditSection( false )

Follow up r48544. Init ParserOptions::mIsPrintable in initialiseFromUser()
Move the "No edit section it's printable" from Parser to Article.
This leaves getIsPrintable() unused. Left there for extensions (none seems to 
be using it, could be removed).

The "even if the user has them on" comment wasn't accurate. The user preference 
only controls them via CSS.
Anyway, it would work as expected now if it got moved into ParserOptions. The 
setEditSection() no longer set it to true.

Remove the quickUserCan( 'edit' ) which is just a hidden way of calling $wgUser 
from the Parser to be explicitely 
done in Article to disable the editsection. This results in quickUserCan being 
called once instead of twice if $wgUseETag == true;.

Comment:

There's no <nowiki>==headers==</nowiki> on that page (on testwiki). I think 
many wiki's put section headers on the relavent message, which is why there's 
edit links on wikinews.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to