User "Bryan" changed the status of MediaWiki.r91642. Old Status: new New Status: fixme
User "Bryan" also posted a comment on MediaWiki.r91642. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91642#c19309 Commit summary: Bug #29755: Apply patch from Vitaliy Filippov so that MW's HTTP client respects no_proxy env setting Comment: * Error suppression operator. Should never be used in new code. * Variable names do not match MediaWiki code conventions. Use $lowerCamelCase. * The absence of code comments, makes it almost impossible to review this. The regexes suggest that you are looking to IPv4 IP addresses. You should use the functions in the IP class for this, and also make this working with IPv6. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
