User "Krinkle" changed the status of MediaWiki.r91642. Old Status: fixme New Status: reverted
User "Krinkle" also posted a comment on MediaWiki.r91642. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91642#c19348 Commit summary: Bug #29755: Apply patch from Vitaliy Filippov so that MW's HTTP client respects no_proxy env setting Comment: Reopening bug 29755, patch wasn't reviewed yet. (or rather, it wasn't a patch/diff at all). I think it was a good experience to trigger code review by committing it (which may have been a coincidence), but I don't think it's something that should be a acceptable way of getting code review. It will only stress developers into maintaining trunk. In a time where pre-commit review is being considered (perhaps even github-like forks and merges, there even are github projects of which the history solely consists of merges! that result from pull-requests that have been reviewed first), this doesn't look good. It's probably easy to turn this into a patch and make it happy with the conventions but to keep the patch simple I've reverted it for now. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
